[wpt-sync] Sync PR 27623 - Introduce <selectmenu> with basic shadow structure and some controller code
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 27623 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/27623
Details from upstream follow.
b'Daniel Clark <daniec@microsoft.com>' wrote:
Introduce <selectmenu> with basic shadow structure and some controller code
Begin implementing the \<selectmenu> element, a version of \<select> with
a fully author-customizable UI.See https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/9TcfjaOs5zg/m/WAiv6WpUAAAJ
and associated links for additional context.Establish the basic shadow DOM structure, with a button (which
includes an arrow icon and a container to show the value), and
a listbox based on \<popup>. There are \<slot> elements to add
\<option>s to the popup and replace any of the default parts.Include some basic styles. The default button part looks something
like the native \<select>, but the default listbox will need more
work to improve its appearance.Add basic controller code using NativeEventListeners. Clicking
the button part opens the listbox \<popup>, and the value property
and text shown in the button are updated when an option is clicked.
This controller code is applied to the default parts and to
author-supplied parts that are included via the \<slot>s.Add tests to validate some basic scenarios involving the
controller code. Note, a couple of the
selectmenu-value.tentative.html
tests fail because updates to the value property are not yet
synchronous (should they be?).There are many TODOs and open questions to investigate, but
this change establishes a starting point for exploring
an approach to customizable form controls.Bug: 1121840
Change-Id: I68c0513b0e30813cbaa3b69fc2acb9086c7400ba
Reviewed-on: https://chromium-review.googlesource.com/2693857
WPT-Export-Revision: 9fb33517e2055462003709d987d81fca37e71f65
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 7 subtests
Status Summary
Firefox
OK : 2
FAIL : 10
Chrome
OK : 2
FAIL : 10
Safari
OK : 1
FAIL : 7
ERROR: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html
Opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: FAIL)
With custom button and popup: opening the popup and clicking an option should change the selectmenu's value: FAIL (Chrome: FAIL)
Clicking a popup with no listbox part does nothing: FAIL (Chrome: FAIL)
/html/semantics/forms/the-selectmenu-element/selectmenu-value.tentative.html
Test that HTMLSelectMenu with no options has empty string for value: FAIL (Chrome: FAIL, Safari: FAIL)
Test value with HTMLOptionElement element option parts: FAIL (Chrome: FAIL, Safari: FAIL)
Test value with non-HTMLOptionElement element option parts: FAIL (Chrome: FAIL, Safari: FAIL)
Test that value is updated when options are removed: FAIL (Chrome: FAIL, Safari: FAIL)
Test that value is updated when the part attribute is removed: FAIL (Chrome: FAIL, Safari: FAIL)
Test that slotted-in selected-value part is updated to value of selectmenu: FAIL (Chrome: FAIL, Safari: FAIL)
Test that option parts in a slotted-in listbox are reflected in the value property: FAIL (Chrome: FAIL, Safari: FAIL)
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7edf34629e5f
https://hg.mozilla.org/mozilla-central/rev/b5c7e71cb851
Description
•