Closed Bug 1692847 Opened 3 years ago Closed 3 years ago

Fix broken use of domWindowOpenedAndLoaded in BrowserTestUtils' promiseAlertDialogOpen

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect)

Desktop
All
defect

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

:darktrojan flagged this up in https://phabricator.services.mozilla.com/D104703 .

Although it appears we could just remove the second argument that's trying to check the URI, it'd probably be more useful to add an optional second argument to domWindowOpenedAndLoaded that checks the URI.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e31236e430ab
fix domWindowOpenedAndLoaded to take a check function, r=darktrojan
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: