1692876 - Perform some clean-ups in (Shared)ArrayBuffer code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[André Bargull [:anba]]

Noticed while working on bug 1692517:

• Remove dead code.
• Reduce indirections.
• Etc.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 1: Remove indirections for ArrayBufferObjectMaybeShared methods. r=jandem!

Inline the various AnyArrayBufferXYZ() functions into the corresponding
ArrayBufferObjectMaybeShared methods.

Drive-by change:
Remove the buf variable in ArrayBufferObjectMaybeShared::dataPointerEither()
for consistency with the other ArrayBufferObjectMaybeShared methods.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 2: Fix isPreparedForAsmJS for shared buffers. r=jandem!

SharedArrayBufferObject doesn't define an isPreparedForAsmJS() method, so
this method was actually calling itself again.

Depends on D105202

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 3: Remove AsAnyArrayBuffer function. r=jandem!

AsAnyArrayBuffer() was only called in a single place in "asm.js". Replace
that call by directly rejecting shared array buffers at the top of CheckBuffer.

Depends on D105203

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 4: Remove unused declarations in array buffer code. r=jandem!

• Remove ArrayBufferObject::OwnsState enum.
• Remove method declarations without definitions.

Depends on D105204

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 5: Remove unused (shared) array buffer functions. r=jandem!

Remove functions which are entirely unused.

Depends on D105205

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 6: Replace the remaining (shared) array buffer helpers with standard is/as() methods. r=jandem!

Use the standard is/as() methods to test/convert (shared) array buffers.

Depends on D105206

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1692876 - Part 7: Use fixed- instead of reserved-slot accessors for SharedArrayObject. r=jandem!

Use {g,s}etFixedSlot() instead of {g,s}etReservedSlot() for consistency with
non-shared array buffers and because it's slightly faster.

Depends on D105207

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fde304dd0f1f
Part 1: Remove indirections for ArrayBufferObjectMaybeShared methods. r=jandem
https://hg.mozilla.org/integration/autoland/rev/8d2942ebab53
Part 2: Fix isPreparedForAsmJS for shared buffers. r=jandem
https://hg.mozilla.org/integration/autoland/rev/d6933e650527
Part 3: Remove AsAnyArrayBuffer function. r=jandem
https://hg.mozilla.org/integration/autoland/rev/e7612e478f48
Part 4: Remove unused declarations in array buffer code. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fcd2d1b118f0
Part 5: Remove unused (shared) array buffer functions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a4e32034b278
Part 6: Replace the remaining (shared) array buffer helpers with standard is/as() methods. r=jandem
https://hg.mozilla.org/integration/autoland/rev/c754d0f1602d
Part 7: Use fixed- instead of reserved-slot accessors for SharedArrayObject. r=jandem

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fde304dd0f1f
https://hg.mozilla.org/mozilla-central/rev/8d2942ebab53
https://hg.mozilla.org/mozilla-central/rev/d6933e650527
https://hg.mozilla.org/mozilla-central/rev/e7612e478f48
https://hg.mozilla.org/mozilla-central/rev/fcd2d1b118f0
https://hg.mozilla.org/mozilla-central/rev/a4e32034b278
https://hg.mozilla.org/mozilla-central/rev/c754d0f1602d