Open Bug 1692929 Opened 3 years ago

Move profiler_add_js{,_allocation}_marker to RegisteredThread.cpp

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

People

(Reporter: mozbugz, Unassigned)

Details

As Florian suggested in https://phabricator.services.mozilla.com/D104587 :

void profiler_add_js_marker(const char* aMarkerName, const char* aMarkerText);
void profiler_add_js_allocation_marker(JS::RecordAllocationInfo&& info);

I'm under the impression that these 2 functions shouldn't be defined in our header, and instead be static functions in tools/profiler/core/RegisteredThread.cpp.

Good idea!

And there are some other functions that could be moved as well, see https://phabricator.services.mozilla.com/D104587 as well.

You need to log in before you can comment on or make changes to this bug.