1692951 - Clicking on the security area of the network section on any website crashes devtools

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Shri]

Attachment: the picture of the stacktrace that was given

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

open devtools on "google.com" or any website
click network section
highlight the base page (google.com/)
change from headers to security

Actual results:

devtools crashes and gives and a "TypeError: can't access property "commonName", subject is undefined"

Expected results:

the security tab should appear

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting!

Comment 3

[Hubert Boma Manilla (:bomsy)]

So it looks like the cert object would be empty if there is an issue
https://searchfox.org/mozilla-central/rev/0379f315c75a2875d716b4f5e1a18bf27188f1e6/devtools/shared/webconsole/network-helper.js#707,731-734

We should take that into consideration and not crash on the frontend here
https://searchfox.org/mozilla-central/rev/0379f315c75a2875d716b4f5e1a18bf27188f1e6/devtools/client/netmonitor/src/components/request-details/SecurityPanel.js#153-174

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1692951 - [devtools] Stop crashing when the security certificate is not available r=honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfef3350019d
[devtools] Stop crashing when the security certificate is not available r=Honza

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bfef3350019d

Comment 7

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9203655 [details]
Bug 1692951 - [devtools] Stop crashing when the security certificate is not available r=honza

Beta/Release Uplift Approval Request

• User impact if declined: Only affects developers
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small javascript change, stop netmonitor crash when a request's security certificate is not available.
• String changes made/needed:

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9203655 [details]
Bug 1692951 - [devtools] Stop crashing when the security certificate is not available r=honza

Too late for 86.

Comment 9

[Hubert Boma Manilla (:bomsy)]

ok thanks pascal!