1692970 - Remove DevTools specific code to handle fixed element in full page screenshot

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

With Bug 1688813 drawSnapshot will handle fixed element, so we don't have to do it from DevTools code.
We can remove this._lastScrollPosition in the screenshotContentActor, which means we can also get rid of captureDone, which was only used to set the original scroll position back.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking DevTools test bugs for Fission M8 (blocking Release experiment).

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1692970 - [devtools] Remove code handling fixed element in screenshot content actor. r=ladybenko.

With Bug 1688813 drawSnapshot will handle fixed element, so we don't have to do
it from DevTools code.

We can remove this._lastScrollPosition in the screenshotContentActor, which means
we can also get rid of captureDone, which was only used to set the original scroll
position back.

We don't have to deal with backward compatibility as the
screenshot content actor was introduced in 87.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0473c8410874
[devtools] Remove code handling fixed element in screenshot content actor. r=ladybenko,devtools-backward-compat-reviewers.

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0473c8410874