remove mozilla::detail::MutexImpl::unlock from sentinel list
Categories
(Socorro :: Signature, defect, P2)
Tracking
(Not tracked)
People
(Reporter: aryx, Assigned: willkg)
References
Details
Attachments
(1 file)
Bug 1687907 added mozilla::detail::MutexImpl::unlock to the sentinel list. This has undesired groupings with new signatures as consequence, e.g. bug 1690753 and @ mozilla::detail::MutexImpl::unlock | free | moz_arena_malloc.
jcristau recommends to drop this sentinel.
|
||
Comment 1•4 years ago
|
||
Hm, I had filed Bug 1687907. While it's not absolutely critical to have mozilla::detail::MutexImpl::unlock on the sentinel list, I am not sure if removing it from the sentinel list is suitable to address the problem. The root cause of these signatures seems to be, as pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=1690753#c3, that CFI isn't working here, and stack scanning produces these garbled stacks.
It might not even be the case that the top frame really is mozilla::detail::MutexImpl::unlock and that's just an unstable artefact of the root problem.
Gabriele, you mentioned in Bug 1687907 that you were going to file another bug to analyze why CFI isn't working in these cases. Did you already do that? I think it's not linked on the other bug.
|
||
Comment 2•4 years ago
|
||
I filed both bug 1691022 and bug 1691020 for addressing issues with CFI and stack-walking on macOS. On x86-64 it seems like we're missing CFI directives and on AArch64 it seems like the stack walker isn't finding frames even though it has CFI information. I don't know when I'll be able to work on them though.
|
Assignee | |
Comment 3•4 years ago
|
||
I'm going to remove mozilla::detail::MutexImpl::unlock from the sentinels list for now. We can re-add it later when things are in a better state stack-walking-wise.
|
|
Assignee | |
Comment 4•4 years ago
|
||
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
|
Assignee | |
Comment 6•4 years ago
|
||
I deployed this to prod in bug #1697897.
Sebastian: Do you want me to reprocess the affected crash reports?
|
Reporter | |
Comment 7•4 years ago
|
||
Thank you. No need to reprocess the existing crash reports from my POV.
|
|
Assignee | |
Comment 8•4 years ago
|
||
Ok. If you need me to later, just let me know.
Description
•