1692987 - [meta] Consider splitting pointerevents wpt test that tests multiple input into separate crate

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, task, P3)

Description

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

Some pointerevents wpt tests multiple input source in one test, like pointerevent_attributes_hoverable_pointers.html tests both mouse and pen input, however, geckodriver currently only support mouse input, and make the whole test reports a harness error like https://wpt.fyi/results/pointerevents/pointerevent_attributes_hoverable_pointers.html?label=experimental&label=master&aligned.

I run the test locally, I found the test do run the test for mouse input, but the result isn't reported, I guess it is suppressed somehow?

It would be good if we could at least run the test and report the result for mouse input, I guess we could

• Split test into a separate crate, each crate for a single input source, e.g. splitting pointerevent_attributes_hoverable_pointers.html into pointerevent_attributes_hoverable_pointers_mouse.html and pointerevent_attributes_hoverable_pointers_pen.html
• Or try to make the error throw from geckodriver doesn't suppress the result of already ran tests, but not sure whether it is possible.

Comment 1

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

jgraham, would you mind shedding some light for comment #0? Thanks!

Comment 2

[James Graham [:jgraham]]

Splitting the tests into seperate HTML files seems like a pretty clear win.

In wptrunner, if a command isn't implementated we get an exception and we end up returning "error" [1], which I think should reject the promise. I'm mildly surprised that in so doing we don't get any results for the parts of the test that ran earlier; but the test is so confusingly structured I'd need to dig in more to figure out what's going on.

[1] https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py#804

Comment 3

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

Close as all dependency has resolved.