1693022 - "Addon:Uninstall" does not fail for unknown add-on ids

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

I'm writing an integration test using Selenium and Firefox (through the geckodriver), in JavaScript. I'm installing an addon using driver.installAddon and uninstalling it using uninstallAddon.

It seems that uninstallAddon never fails, even if the addon to be uninstalled is not there. Is this a bug?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The method is implemented here:
https://searchfox.org/mozilla-central/rev/a23e65c5d69a821f61d14c8ec1f69a120e3f77d1/testing/marionette/addon.js#109-134

I wonder what AddonManager.getAddonByID() actually returns in such a case. Here it's implementation:
https://searchfox.org/mozilla-central/rev/a23e65c5d69a821f61d14c8ec1f69a120e3f77d1/toolkit/mozapps/extensions/AddonManager.jsm#2687

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

I wonder what AddonManager.getAddonByID() actually returns in such a case. Here it's implementation:
https://searchfox.org/mozilla-central/rev/a23e65c5d69a821f61d14c8ec1f69a120e3f77d1/toolkit/mozapps/extensions/AddonManager.jsm#2687

It seems to return null in that case: using the script directly in the "chrome" context works fine!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, so our Promise handling is broken given that we do not catch the failure when accessing candidate.uninstall().

So I would suggest to use await and then also a null check.

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1693022 - Report errors when uninstalling unknown addons in marionette. r?whimboo

The AddonManager does not throw, but instead reports null, when
trying to get information about an addon if the id is unknown.
This makes sure marionette addresses this case.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd7229f4587
Report errors when uninstalling unknown addons in marionette. r=whimboo,marionette-reviewers

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cbd7229f4587