1693046 - Remove JSClass parameter from NewObjectGCKind

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[André Bargull [:anba]]

Remove JSClass parameter from NewObjectGCKind because it's effectively unused.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1693046: Remove JSClass parameter from NewObjectGCKind. r=jandem!

js::CreateThis() calls into NewObject() via NewObjectWithClassProto(),
and NewObject() asserts when the class is either ArrayObject::class_ or
JSFunction::class_ and the AllocKind is neither AllocKind::FUNCTION nor
AllocKind::FUNCTION_EXTENDED. That means js::CreateThis() is never called
for arrays and functions and therefore it's okay to ignore the JSClass*
passed to NewObjectGCKind().

Also remove the reference to bug 547327, because the bug has been closed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78953b4969b3
Remove JSClass parameter from NewObjectGCKind. r=jandem

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/78953b4969b3