1693050 - Update extension removal warning content/text

Status: VERIFIED FIXED

(WebExtensions :: Frontend, enhancement, P2)

Description

[:Gijs (he/him)]

For proton, we want to drop the redundant message text (the title is "Remove {Addon}?", we don't need the additional message of "Remove {Addon} from Firefox?").

This may need logic changes in the prompt handling code.

We also want to simplify the checkbox text to "Report this extension to Mozilla", and add a question mark to the dialog title (ie "Remove {Addon}?").

Finally, we should make sure this consistently uses the window-modal dialog style from bug 1685313 (which might mean changing the parentWindow argument passed when displaying the prompt).

Comment 1

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1693050 - Update extension removal warning content.

• Add a question mark to the prompt title.
• Simplify the report-abuse message to always say Mozilla.
• Use prompt to use new tab-modal format.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/870e11561811
Update extension removal warning content. r=Gijs,fluent-reviewers,mixedpuppy

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 870e11561811 (Bug 1693050) for bc failures in browser_history_navigation.js.
https://hg.mozilla.org/integration/autoland/rev/fc8844cb8c0d09f0d51a879f4d9fc430a9f61a7b

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=870e115618111b92d218d0d8051c298b4cf8937e&selectedTaskRun=KFx8GyjbTai2k5tnn_5QAw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=332751782&repo=autoland&lineNumber=5603

Comment 5

[Cristian Brindusan [:cbrindusan]]

There are also some bc failures on browser_ext_browserAction_contextMenu.js.
https://treeherder.mozilla.org/logviewer?job_id=332751813&repo=autoland&lineNumber=2309

Comment 6

[Erik Nordin [:nordzilla]]

Added some fixes. Going to try landing this again.

Try looks clean on my end: https://treeherder.mozilla.org/jobs?repo=try&revision=0ea71b1f4c8adf72c4e6dac6251e6cf1f2e6dc88

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92bf9607e3c7
Update extension removal warning content. r=Gijs,fluent-reviewers,mixedpuppy

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/92bf9607e3c7

Comment 9

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit)

• question mark was added to the prompt title.
• new tab-modal format is shown
• the title is "Remove {Addon}?", the additional message of "Remove {Addon} from Firefox?" was removed.
• checkbox text reads "Report this extension to Mozilla"

Updating status accordingly.
Best regards,
Clara