1693068 - CustomElementRegistry::WhenDefined creates a Promise, which might not be used

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Simon Giesecke [:sg] [he/him]]

CustomElementRegistry::WhenDefined creates a Promise at the very beginning, but it might not be used: When the function reaches the final return statement, and there already is an entry in mWhenDefinedPromiseMap, it is just discarded. This could be refactored so that a Promise is only created in the cases where it's needed.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693068 - Use function to lazily create a Promise when needed in CustomElementRegistry::WhenDefined. r=#xpcom-reviewers

Depends on D104676

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85548fff7e00
Use function to lazily create a Promise when needed in CustomElementRegistry::WhenDefined. r=emilio

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/85548fff7e00