1693074 - Adding telemetries to measure the critical path of ServiceWorker Performance

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P2)

Description

[Eden Chuang[:edenchuang]]

Knowing how long registration loading blocked the main thread for the initialization of ServiceWorkerManager which was the delta between "getRegistrationsDone" and "getRegistrationsWaiting" in https://hg.mozilla.org/try/rev/d86fc75d9e4c36d317e62a4eaa5d3a85db40f4b7#l3.44

Knowing how long we blocked waiting for the directory lock for the underlying Cache API storage for the ServiceWorker which was teh delta between "ready" and "start" in https://hg.mozilla.org/try/rev/d86fc75d9e4c36d317e62a4eaa5d3a85db40f4b7#l1.53

Knowing how long it took between the "spawn" request (https://hg.mozilla.org/try/rev/8654ba8d338cfb36c3b3098c3fbc529fdfcedad9#l17.81) for the (remote) ServiceWorker (as perceived in the parent process) and the "creationSucceeded" (https://hg.mozilla.org/try/rev/d6a65cab1f04042d5c465a44051278bb5c2a0587#l3.72) (which covers the top level script evaluation as well)

Knowing how long it takes the navigation "fetch" event to be responded to: currently I get that from the time between "asyncOpenInternal" on the intercepted channel (https://hg.mozilla.org/try/rev/8654ba8d338cfb36c3b3098c3fbc529fdfcedad9#l32.30) and the "startSynthesizedResponse" (https://hg.mozilla.org/try/rev/8654ba8d338cfb36c3b3098c3fbc529fdfcedad9#l32.247).

Knowing how long it takes for that response to be pumped into the chanel, which is basically the time between startSynthesizedResponse and onStopRequest (https://hg.mozilla.org/try/rev/8654ba8d338cfb36c3b3098c3fbc529fdfcedad9#l32.268)

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1693074 - P1 Adding telemetries for measuring performance ServiceWorker register flow

Comment 2

[Jens Stutte [:jstutte]]

Eden, are you actively working on this? Thanks!

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1693074 - Remove child interception telemetries related codes. r=#dom-worker-reviewers

Comment 4

[Eden Chuang[:edenchuang]]

Attachment: Bug 1693074 - Adding telemetry for spawning service worker. r=#dom-worker-reviewers

Depends on D118396

Comment 5

[Eden Chuang[:edenchuang]]

Attachment: Bug 1693074 - Adding telemetry for evaluating whole fetch interception duration. r=#dom-worker-reviewers

Depends on D118397

Comment 6

[Eden Chuang[:edenchuang]]

Attachment: Bug 1693074 - Adding telemetry for evaluating the duration of fetch event dispatching and response synthesizing. r=#dom-worker-reviewers

Depends on D118398

Comment 7

[Eden Chuang[:edenchuang]]

Attachment: request_bug1693074.md

Comment 8

[Chris H-C :chutten]

Comment on attachment 9235591 [details]
request_bug1693074.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Eden Chuang is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/443f9c6e3d1e
Remove child interception telemetries related codes. r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/8e18c2eb0aac
Adding telemetry for spawning service worker. r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/cf74310b0c84
Adding telemetry for evaluating whole fetch interception duration. r=dom-worker-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/43eb6ce90ab0
Adding telemetry for evaluating the duration of fetch event dispatching and response synthesizing. r=dom-worker-reviewers,asuth

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/443f9c6e3d1e
https://hg.mozilla.org/mozilla-central/rev/8e18c2eb0aac
https://hg.mozilla.org/mozilla-central/rev/cf74310b0c84
https://hg.mozilla.org/mozilla-central/rev/43eb6ce90ab0