Closed Bug 1693091 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27646 - [LayoutNG] Replace column break tokens during OOF fragmentation

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27646 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27646
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Replace column break tokens during OOF fragmentation

If a column fragment is updated during nested fragmentation of OOF
positioned elements, we currently replace the column fragment in its
existing multicol parent fragment. However, that column fragment
may also have a break token that is referenced in its parent's list
of child break tokens. This change adds support for replacing such
break tokens by exposing a mutable part of an NGBlockBreakToken.

Bug: 1079031
Change-Id: I371eb8766067b7150759c8a29e0a6c7678f248b3
Reviewed-on: https://chromium-review.googlesource.com/2692357
WPT-Export-Revision: 883bb399c7e1249b86ba1c04f52a972afd8ede85

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/out-of-flow-in-multicolumn-018.html: FAIL

New Tests That Don't Pass

/css/css-break/out-of-flow-in-multicolumn-018.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33c50b717add
[wpt PR 27646] - [LayoutNG] Replace column break tokens during OOF fragmentation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d25ec3b1e297
[wpt PR 27646] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/33c50b717add
https://hg.mozilla.org/mozilla-central/rev/d25ec3b1e297

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.