1693138 - In OpenPGP message security info (received message), allow copying the signer key ID

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert (:KaiE:)]

This might be a regression introduced by the doorhanger reworking of the security info dialog - but I'm not completely sure it has worked before.

Receive an email with an OpenPGP signature.
Click the OpenPGP icon to open the security info.

A "signer key id" information is shown:

Expected behavior: It should be possible to "select and copy" the key ID - that's necessary to search for that key ID elsewhere.

Comment 1

[Alessandro Castellani [:aleca]]

I can make the elements inside the security panel selectable.
Which elements should we allow to be selected/copied?

Comment 2

[Kai Engert (:KaiE:)]

(In reply to Alessandro Castellani (:aleca) from comment #1)

I can make the elements inside the security panel selectable.
Which elements should we allow to be selected/copied?

The dialog may show (a) "signer key id", followed by (b) key ID string, followed by a button (if we have that key already).

We should at least allow (b) to be copied.
It looks like (a) and (b) might be a combined string, if true, then I think it's the easiest to allow the whole string to be selected/copied.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 1693138 - Make the key and signature parts of the message security popup selectable. r=KaiE

Comment 4

[Kai Engert (:KaiE:)]

Attachment: 1693138-esr78.patch

merged patch for esr78

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 9207184 [details]
Bug 1693138 - Make the key and signature parts of the message security popup selectable. r=KaiE

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: helpful information not selectable
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52cec66c73d5
Make the key and signature parts of the message security popup selectable. r=KaiE

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9207184 [details]
Bug 1693138 - Make the key and signature parts of the message security popup selectable. r=KaiE

[Triage Comment]
Approved for beta

Comment 8

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-beta/rev/c570b1a6bba5b826772a0ccc879c1fb6ba3c36c4

Comment 9

[Kai Engert (:KaiE:)]

Comment on attachment 9208036 [details] [diff] [review]
1693138-esr78.patch

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: cannot use copy/paste for important information
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9208036 [details] [diff] [review]
1693138-esr78.patch

[Triage Comment]
Approved for esr78

Comment 11

[Kai Engert (:KaiE:)]

78.9.1
https://hg.mozilla.org/releases/comm-esr78/rev/ee94f9bda697bca87f0dc83c4e5bc8b17a69e95f