1693346 - Test failure in layout/reftests/forms/input/range/auto-size.html with NNT

Status: RESOLVED FIXED

(Core :: Widget, defect, P2)

Description

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f9c48877a37d70edf50a9dd6cccc3b140d0f6ff8&selectedTaskRun=aAkGKfmUSXy07-AGisX2-Q.0

Reftest analyzer

There are two types of problems shown in the reftest:

1. The bottom of thumb's shadow is clipped in the test but not in the reftest.
2. The right edge of the scale track has a slight variation in the gray values.

For 1, I think we need to make sure that the shadow only renders inside the stated widget overflow rect; either by increasing the size of the overflow rect, or by clipping the shadow (and maybe slightly reducing its radius).
For 2, I think we can add a slight fuzzy declaration to the reftest manifest.

Comment 1

[Markus Stange [:mstange]]

Hmm, we already report a 6px overflow margin for StyleAppearance::Range, and PaintRange already clips to that overflow rect. Then I'm not sure why the shadow is sometimes clipped and sometimes not.
This might require more debugging, so I'm unassigning myself again.

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Bug 1693346: Adjust fuzziness for auto-size.html to make this test pass on macOS as well when the non-native theme is enabled. r=emilio,mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20e3de799627
Adjust fuzziness for auto-size.html to make this test pass on macOS as well when the non-native theme is enabled. r=mstange

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/20e3de799627