Closed
Bug 1693373
Opened 3 years ago
Closed 3 years ago
Button variant control broken in nightly
Categories
(Firefox :: Pocket, defect)
Firefox
Pocket
Tracking
()
RESOLVED
FIXED
87 Branch
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
I want to highlight that this is just in nightly. Our experiment that uses this is in beta, so this shouldn't impact our experiment. This broke because of bug 1690608
Two patches landed in a similar timeframe, and wasn't caught in a rebase.
Essentially, the 1 button experiment control variant is busted, showing a blank iframe instead of a signup panel.
It's just missing an initial height value. It's missing because it was like control.
So I'm also going to build in a fallback so if this happens (a variant is missing an initial height) to fallback to the control values.
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → sdowne
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
To test:
- Log out of Pocket if you are logged into Pocket.
- Change extensions.pocket.loggedOutVariant to "button_contro"
- Try to save an article.
Expected: should see a login page, and not an empty grey page.
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/2f7ca27cd647 Save to Pocket button 1 button experiment control variant fix. r=gvn
Comment 4•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•