Closed Bug 1693385 Opened 3 years ago Closed 3 years ago

support manifest.host_permissions

Categories

(WebExtensions :: General, enhancement, P1)

enhancement

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: mixedpuppy, Assigned: zombie)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete, Whiteboard: mv3:m2 [mv3-m2])

Attachments

(1 file)

No description provided.
Whiteboard: mv3:m2
Whiteboard: mv3:m2 → mv3:m2 [mv3-m2]
Assignee: nobody → tomica
Depends on: 1671244
Priority: -- → P1

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:zombie, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(tomica)
Flags: needinfo?(mixedpuppy)
Flags: needinfo?(tomica)
Flags: needinfo?(mixedpuppy)
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/540fd6bb70bd
Support manifest.host_permissions for MV3 r=mixedpuppy

Backed out for failures on test_ext_webSocket.js

[task 2021-07-24T20:27:13.981Z] 20:27:13     INFO -  TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_webSocket.js
[task 2021-07-24T20:27:14.785Z] 20:27:14  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_webSocket.js | xpcshell return code: 0
[task 2021-07-24T20:27:14.785Z] 20:27:14     INFO -  TEST-INFO took 804ms
[task 2021-07-24T20:27:14.785Z] 20:27:14     INFO -  >>>>>>>
[task 2021-07-24T20:27:14.785Z] 20:27:14     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-07-24T20:27:14.786Z] 20:27:14     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-07-24T20:27:14.786Z] 20:27:14     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-07-24T20:27:14.786Z] 20:27:14     INFO -  running event loop
[task 2021-07-24T20:27:14.787Z] 20:27:14     INFO -  xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_webSocket.js | Starting check_remote
[task 2021-07-24T20:27:14.787Z] 20:27:14     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2021-07-24T20:27:14.787Z] 20:27:14     INFO -  TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_webSocket.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - true == true
Flags: needinfo?(tomica)

Fixed test_ext_webSocket.js which landed in-between.

Flags: needinfo?(tomica)
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3881437c0949
Support manifest.host_permissions for MV3 r=mixedpuppy
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1722966
Keywords: dev-doc-needed

Summary for documentation: for MV3 extensions, the permissions keys is only used for API permissions, while the new host_permissions key is used for OriginPermissions (or MatchPatterns).

https://phabricator.services.mozilla.com/D118305#change-usLdbxehvswa

Does this need to documenting ahead of the overall MV3 changes?

Flags: needinfo?(tomica)

Not really, this is part of the manifest format changes for MV3 and can be done at the same time.

Flags: needinfo?(tomica)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: