Closed Bug 1693447 Opened 4 years ago Closed 4 years ago

Fix rectangle clips being ignored in some cases in wrench.

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: gw, Assigned: gw)

Details

Attachments

(1 file)

No description provided.

Wrench (and probably other applications) start numbering pipeline
IDs from (0,0). The ClipChainBuilder code uses PipelineId::dummy()
as a sentinel ID to cache the previously built clip-chain.

In some cases, this would result in the clip-chain incorrectly
being skipped. To avoid this, make PipelineId::dummy() be a
more unlikely value that clients will use. Also add a wrench test
to check this case.

Assignee: nobody → gwatson
Status: NEW → ASSIGNED
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4937867616b7 Fix rectangle clips being ignored in some cases in wrench. r=nical
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: