1693541 - Improve code that does multiple subsequent nsBaseHashtable lookups for the same key

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups.

Depends on D105479

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/localstorage. r=#dom-storage

Depends on D105788

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/quota. r=#dom-storage

Depends on D106089

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/storage. r=#dom-storage

Depends on D106090

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/indexedDB. r=#dom-storage

Depends on D106091

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in accessible. r=Jamie

Depends on D106092

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in xpcom. r=#xpcom-reviewers

Depends on D106093

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/media. r=bryce

Depends on D106094

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in gfx. r=jrmuizel

Depends on D106095

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in netwerk. r=#necko-reviewers

Depends on D106096

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in storage. r=mak

Depends on D106097

Comment 12

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in layout. r=emilio

Depends on D106098

Comment 13

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in uriloader. r=Gijs

Depends on D106099

Comment 14

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in dom/gamepad. r=handyman

Depends on D106100

Comment 15

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in security/manager/ssl/DataStorage.cpp. r=keeler

Depends on D106101

Comment 16

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/ipc. r=nika

Depends on D106102

Comment 17

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/animation. r=emilio

Depends on D106103

Comment 18

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/base. r=smaug

Depends on D106104

Comment 19

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in image. r=tnikkel

Depends on D106105

Comment 20

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/plugins. r=masayuki

Depends on D106106

Comment 21

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/file. r=baku

Depends on D106107

Comment 22

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in nsSystemAlertsService. r=MattN

Depends on D106108

Comment 23

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in toolkit/components/url-classifier. r=gcp

Depends on D106109

Comment 24

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants in toolkit/components/telemetry. r=chutten

Depends on D106110

Comment 25

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/html. r=mattwoodrow

Depends on D106111

Comment 26

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in toolkit/components/resistfingerprinting. r=tjr

Depends on D106112

Comment 27

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in toolkit/components/perfmonitoring. r=florian

Depends on D106113

Comment 28

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in toolkit/components/extensions. r=ckerschb

Depends on D106114

Comment 29

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in security/sandbox/linux/broker. r=jld

Depends on D106115

Comment 30

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in intl/locale. r=jfkthame

Depends on D106116

Comment 31

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/presentation/ipc. r=nika

Depends on D106117

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/024f13738341
Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in storage. r=mak
https://hg.mozilla.org/integration/autoland/rev/c1dd5f0c12ae
Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in toolkit/components/url-classifier. r=gcp
https://hg.mozilla.org/integration/autoland/rev/3fb278f4f22a
Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in dom/gamepad. r=handyman
https://hg.mozilla.org/integration/autoland/rev/7e0af52987b7
Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in image. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/368eaba844c1
Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in toolkit/components/resistfingerprinting. r=tjr
https://hg.mozilla.org/integration/autoland/rev/dd71da0eaaae
Improve uses of nsBaseHashtable and descendants in toolkit/components/telemetry. r=chutten

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27f574662450
Improve uses of nsBaseHashtable and descendants by using Contains instead of Get in dom/gamepad. r=handyman. CLOSED TREE

Comment 34

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/024f13738341
https://hg.mozilla.org/mozilla-central/rev/c1dd5f0c12ae
https://hg.mozilla.org/mozilla-central/rev/3fb278f4f22a
https://hg.mozilla.org/mozilla-central/rev/7e0af52987b7
https://hg.mozilla.org/mozilla-central/rev/368eaba844c1
https://hg.mozilla.org/mozilla-central/rev/dd71da0eaaae
https://hg.mozilla.org/mozilla-central/rev/27f574662450

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ad72338c85c
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/plugins. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/bd94eb676ba3
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in intl/locale. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5bf56df77c01
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in uriloader. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/f0a9f8d39f4d
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/base. r=smaug
https://hg.mozilla.org/integration/autoland/rev/32a4e7eb5368
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in toolkit/components/perfmonitoring. r=florian
https://hg.mozilla.org/integration/autoland/rev/41188177fe20
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in layout. r=emilio
https://hg.mozilla.org/integration/autoland/rev/df77b47527fd
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/storage. r=dom-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/dadbd4ea6fc2
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/media. r=bryce
https://hg.mozilla.org/integration/autoland/rev/aa78994028cf
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in security/manager/ssl/DataStorage.cpp. r=keeler

Comment 36

[Dorel Luca [:dluca]]

Backed out changeset dadbd4ea6fc2 (bug 1693541) for Browser-chrome failures in dom/media/mediacontrol/tests/browser/browser_media_control_audio_focus_within_a_page.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=331333871&repo=autoland&lineNumber=11246

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuperseded%2Cusercancel%2Cretry%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=aa78994028cf5d738fed2bc632ec8cb5495a4ccf

Backout:
https://hg.mozilla.org/integration/autoland/rev/ee2549b36bbe52a9f97cf1cad591ef2952403d95

Comment 37

[Simon Giesecke [:sg] [he/him]]

(In reply to Dorel Luca [:dluca] from comment #36)

Backed out changeset dadbd4ea6fc2 (bug 1693541) for Browser-chrome failures in dom/media/mediacontrol/tests/browser/browser_media_control_audio_focus_within_a_page.js. CLOSED TREE

Interesting, locally this test is failing for me even without any of these patches.

Comment 38

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1ad72338c85c
https://hg.mozilla.org/mozilla-central/rev/bd94eb676ba3
https://hg.mozilla.org/mozilla-central/rev/5bf56df77c01
https://hg.mozilla.org/mozilla-central/rev/f0a9f8d39f4d
https://hg.mozilla.org/mozilla-central/rev/32a4e7eb5368
https://hg.mozilla.org/mozilla-central/rev/41188177fe20
https://hg.mozilla.org/mozilla-central/rev/df77b47527fd
https://hg.mozilla.org/mozilla-central/rev/aa78994028cf

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473b37f1e3e2
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in gfx. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/de453865d38b
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/html. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/1126b4b88325
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in accessible. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/67598c4cd48a
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/localstorage. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/552b59db5620
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/quota. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/cbb8f0428372
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/indexedDB. r=dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/596f4d937a00
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in xpcom. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/ead409cf4b20
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/file. r=baku
https://hg.mozilla.org/integration/autoland/rev/6d024458a59e
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in toolkit/components/extensions. r=robwu

Comment 40

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/473b37f1e3e2
https://hg.mozilla.org/mozilla-central/rev/de453865d38b
https://hg.mozilla.org/mozilla-central/rev/1126b4b88325
https://hg.mozilla.org/mozilla-central/rev/67598c4cd48a
https://hg.mozilla.org/mozilla-central/rev/552b59db5620
https://hg.mozilla.org/mozilla-central/rev/cbb8f0428372
https://hg.mozilla.org/mozilla-central/rev/596f4d937a00
https://hg.mozilla.org/mozilla-central/rev/ead409cf4b20
https://hg.mozilla.org/mozilla-central/rev/6d024458a59e

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28cee8e01f34
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in netwerk. r=necko-reviewers,valentin

Comment 42

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/28cee8e01f34

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f463bd181bdd
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/presentation/ipc. r=nika

Comment 44

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There are Nightly crashes for the gfx change https://hg.mozilla.org/mozilla-central/rev/473b37f1e3e2 - e.g. bp-22b9b3b0-82d5-4427-9c77-448360210302
The change will be reverted and new Nightlies requested.

Comment 45

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/fd31ad9db5ad
Backed out changeset 473b37f1e3e2 for causing gfx crashes. a=backout

Comment 46

[Sandor Molnar[:smolnar]]

Backed out from central for causing gfx crashes

Backout link: https://hg.mozilla.org/mozilla-central/rev/fd31ad9db5ad7f2bad07cdaa785e463bdc0a98b3

Comment 47

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The backout conflicts with bug 1691913. Simon, please connect with the #sheriffs channel on the next step (test fix or backout).

Comment 48

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1693541 - Revert changes to FindAndAddFamilies and adapt to nsBaseHashtable changes.

Depends on D106096

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1cd6272a3459
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in gfx. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/b2c9624b48f0
Revert changes to FindAndAddFamilies and adapt to nsBaseHashtable changes. a=fix

Comment 50

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d9143bf5e68
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/media. r=bryce

Comment 51

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f463bd181bdd
https://hg.mozilla.org/mozilla-central/rev/6d9143bf5e68

Comment 52

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90183d6fc8ce
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in nsSystemAlertsService. r=karlt

Comment 53

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/90183d6fc8ce

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c247b91b08b6
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/ipc. r=nika

Comment 55

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c247b91b08b6

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa6ad2529eaf
Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in security/sandbox/linux/broker. r=jld

Comment 57

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/aa6ad2529eaf