[wpt-sync] Sync PR 27677 - Consider the hyhen size in the available width when evaluating overflow
Categories
(Core :: Layout: Text and Fonts, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 27677 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/27677
Details from upstream follow.
b'Javier Fern\xc3\xa1ndez Garc\xc3\xada-Boente <jfernandez@igalia.com>' wrote:
Consider the hyhen size in the available width when evaluating overflow
The logic in NGLineBreaker::BreakText completes the algorithm by
evaluating whether the NGInlineItem inline size fits in the available
width, received in the function argument "available_width".However, when hyphenation is applied, we reduce this initial available
width, subtracting the hyphen inline size, and run another iteration of
the ShapeLine() function. The new item's inline size is evaluated again
to check whether it overflows or not.The root case of the issue described in the bug is that we are using the
value stored in the available_width variable, which we've just reduced
because of hyphenation. We should use the available_width_with_hyphens
variable instead.Bug: 1175716
Change-Id: I3ecac2362f7cf9951cd0d323a7b163385d240f89
Reviewed-on: https://chromium-review.googlesource.com/2704079
WPT-Export-Revision: 7c2547e30e98fc1f6734621bdd8dc477e6d9b9e2
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
FAIL: 1
Safari
FAIL: 1
Links
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•