1693611 - Move stencil-related XDR logic from Xdr.cpp into StencilXdr.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

before working on bug 1693184, it's better gathering "buffer structure"-related code into single place.

Currently header and ParserAtomTable code is written in Xdr.cpp, and CompilationStencil code is written in StencilXdr.cpp.
After bug 1687095, the buffer structure is simple that there's one header (version, source), one ParserAtomTable, and one remaining CompilationStencil fields,
and it means it's just version + whole CompilationStencil.

Inlining header function and XDRCompilationStencil function will simplify the structure hierarchy inside code.
And that lets us adding markers in bug 1693184 cleanly.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 1: Move vector/span related XDR functions before others.

Depends on D105910

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 1: Rename StencilXDR::BigInt to StencilXDR::codeBigInt.

Subsequent patches move other XDR functions into StencilXDR.
To avoid name collision between method and type name, prepend code to method.

Also reorder to match the field order.

Depends on D105911

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 2: Rename StencilXDR::ObjLiteral to StencilXDR::codeObjLiteral.

Depends on D105912

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 3: Rename StencilXDR::ScopeData to StencilXDR::codeScopeData.

Depends on D105913

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 4: Rename StencilXDR::SharedData to StencilXDR::codeSharedData.

Depends on D105914

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 5: Move ParserAtom XDR functions to StencilXDR.

Depends on D105915

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 6: Move StencilModuleMetadata XDR functions to StencilXDR.

Depends on D105916

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 7: Move XDRCheckCompilationStencil to StencilXDR.

Depends on D105917

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 8: Move XDRCompilationStencil to StencilXDR.

Depends on D105918

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 9: Remove unnecessary alignment padding between header and CompilationStencil.

Now the header and CompilationStencil are encoded into the same buffer,
and the alignment padding isn't necessary.

Depends on D105919

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 10: Remove XDRStencilDecoder::stencilAlloc_.

Depends on D105920

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 11: Remove XDRStencilDecoder::{hasOptions,options}.

Depends on D105921

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693611 - Part 12: Use XDRStencilEncoder from XDRIncrementalStencilEncoder. r=mgaudet

Depends on D105922

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e435a571803
Part 1: Rename StencilXDR::BigInt to StencilXDR::codeBigInt. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0d66ecd8acd4
Part 2: Rename StencilXDR::ObjLiteral to StencilXDR::codeObjLiteral. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/fb2c167165b8
Part 3: Rename StencilXDR::ScopeData to StencilXDR::codeScopeData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6f06ff0ebbc3
Part 4: Rename StencilXDR::SharedData to StencilXDR::codeSharedData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/72fc08b6245d
Part 5: Move ParserAtom XDR functions to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/faacbf1943b6
Part 6: Move StencilModuleMetadata XDR functions to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/565bee5296ac
Part 7: Move XDRCheckCompilationStencil to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a4ff4b030aaa
Part 8: Move XDRCompilationStencil to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7bf683fab589
Part 9: Remove unnecessary alignment padding between header and CompilationStencil. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/4928193b996f
Part 10: Remove XDRStencilDecoder::stencilAlloc_. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/8fd50eba1621
Part 11: Remove XDRStencilDecoder::{hasOptions,options}. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0069d43ee2c4
Part 12: Use XDRStencilEncoder from XDRIncrementalStencilEncoder. r=mgaudet

Comment 15

[Atila Butkovits]

Backout info: https://bugzilla.mozilla.org/show_bug.cgi?id=1693184#c4

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d25a0b774152
Part 1: Rename StencilXDR::BigInt to StencilXDR::codeBigInt. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e43244daf953
Part 2: Rename StencilXDR::ObjLiteral to StencilXDR::codeObjLiteral. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/4482d794a4da
Part 3: Rename StencilXDR::ScopeData to StencilXDR::codeScopeData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/68823de0b29d
Part 4: Rename StencilXDR::SharedData to StencilXDR::codeSharedData. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a435c1f3dfaa
Part 5: Move ParserAtom XDR functions to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a4994838b654
Part 6: Move StencilModuleMetadata XDR functions to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/5ce159cb3ccb
Part 7: Move XDRCheckCompilationStencil to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/5b208e65863b
Part 8: Move XDRCompilationStencil to StencilXDR. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/35608d119e96
Part 9: Remove unnecessary alignment padding between header and CompilationStencil. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1205a7afc825
Part 10: Remove XDRStencilDecoder::stencilAlloc_. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/144d29ce8c6a
Part 11: Remove XDRStencilDecoder::{hasOptions,options}. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/de28c772a038
Part 12: Use XDRStencilEncoder from XDRIncrementalStencilEncoder. r=mgaudet

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d25a0b774152
https://hg.mozilla.org/mozilla-central/rev/e43244daf953
https://hg.mozilla.org/mozilla-central/rev/4482d794a4da
https://hg.mozilla.org/mozilla-central/rev/68823de0b29d
https://hg.mozilla.org/mozilla-central/rev/a435c1f3dfaa
https://hg.mozilla.org/mozilla-central/rev/a4994838b654
https://hg.mozilla.org/mozilla-central/rev/5ce159cb3ccb
https://hg.mozilla.org/mozilla-central/rev/5b208e65863b
https://hg.mozilla.org/mozilla-central/rev/35608d119e96
https://hg.mozilla.org/mozilla-central/rev/1205a7afc825
https://hg.mozilla.org/mozilla-central/rev/144d29ce8c6a
https://hg.mozilla.org/mozilla-central/rev/de28c772a038