1693625 - Use soft-error instead of/in addition to release assert during XDR decode

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

We use mozilla::Span in the CompilationStencil, and out-of-range access hits release-assert.
If we have such branch anyway, it's better returning soft error (JS::TranscodeResult_Failure_BadDecode),
assuming that XDR buffer can contain error (bit flip etc).

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693625 - Use soft-error for out-of-bound ParserAtomSpan index while decoding.

Depends on D105923

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5353d36c4846
Use soft-error for out-of-bound ParserAtomSpan index while decoding. r=mgaudet

Comment 3

[Atila Butkovits]

Backout info: https://bugzilla.mozilla.org/show_bug.cgi?id=1693184#c4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/367741ac0bf5
Use soft-error for out-of-bound ParserAtomSpan index while decoding. r=mgaudet

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1693625 - Use soft-error for out-of-bound ParserAtomSpan index while decoding. r=mgaudet!

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 9207688 [details]
Bug 1693625 - Use soft-error for out-of-bound ParserAtomSpan index while decoding. r=mgaudet!

Beta/Release Uplift Approval Request

• User impact if declined: Crash while loading a webpage (bug 1693137), if there's data corruption in bytecode cache data.
  That is likely a signature change from existing other bugs (see bug 1693137 comment #9).

There's no automated-test or manual-test. we'll check crash stats for the effect.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This changes a crash on cache data corruption to fallback path, that aborts using the cache.
• String changes made/needed: None

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/367741ac0bf5

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9207688 [details]
Bug 1693625 - Use soft-error for out-of-bound ParserAtomSpan index while decoding. r=mgaudet!

approved for 87.0b8

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a25c9926725d