1693670 - Exceptions in CardDAV sync operations shouldn't prevent the next sync

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Currently if an exception is thrown during syncing, the next sync isn't scheduled. We could probably also handle exceptions better (like providing some user feedback) but for now I'm just going to put a try/finally block around the sync operations.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1693670 - Do CardDAV sync in a try/finally block so the next sync is always scheduled. r?mkmelin

Depends on D105694

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3b7f3fbc2201
Do CardDAV sync in a try/finally block so the next sync is always scheduled. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

Uplift or not?

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9204078 [details]
Bug 1693670 - Do CardDAV sync in a try/finally block so the next sync is always scheduled. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: carddav sync errors cause it to stop syncing for the rest of the session
Testing completed (on c-c, etc.): in 87 beta
Risk to taking this patch (and alternatives if risky): no risk

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9204078 [details]
Bug 1693670 - Do CardDAV sync in a try/finally block so the next sync is always scheduled. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/33ef73cd30dd