1693683 - Cannot drag tabs, toolbar, and web content with pen, on macOS

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. run nightly 87.0a1 (2021-02-18) (64-bit) with clean profile, on macOS, with Wacom intuos Pro connected
2. Hit Ctrl+T 4 times to open multiple tabs
3. drag tabs using pen
4. Hit Ctrl+N to open new window
5. Hit Ctrl+T 4 times to open multiple tabs
6. drag tabs using pen

Expected result:
I can drag the tab to reorder or detach

Actual result:
I cannot drag the tab, sometimes on step 3, and always on step 6.

Comment 1

[Tooru Fujisawa [:arai]]

This is major usability issue when using pen as primary pointing device.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

This should ultimately be restored by dom.w3c_pointer_events.dispatch_by_pointer_messages by firing touch events properly, but yeah, it should be disabled only if the flag is checked for now.

Comment 3

[Tooru Fujisawa [:arai]]

regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2dc693aa4abd27f58ca17178c33e1500195270ab&tochange=d3d6dc34e64aef00841c8297c03139f13bd8befd

Also this affects toolbar customization, bookmark item's reordering as well.

[Tracking Requested - why for this release]: Users who uses pen as primary pointing device cannot operate on browser with drag

Comment 4

[Tooru Fujisawa [:arai]]

oh, also I cannot invoke drag event on web content.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

(In reply to Tooru Fujisawa [:arai] from comment #4)

oh, also I cannot invoke drag event on web content.

Can you invoke drag event in Chrome? We are planning to consume the new WM_POINTER_* events and it's known that Windows does not allow drag and drop with it.

Comment 6

[Tooru Fujisawa [:arai]]

(In reply to Kagami :saschanaz from comment #2)

This should ultimately be restored by dom.w3c_pointer_events.dispatch_by_pointer_messages by firing touch events properly, but yeah, it should be disabled only if the flag is checked for now.

I see that the pref is mentioned in several places online, and I'd expect some pen tablet users enabled the pref.

• https://github.com/photopea/photopea/issues/1598
• https://stackoverflow.com/questions/50783744/wacom-in-a-browser-cancels-movement
• https://bugzilla.mozilla.org/show_bug.cgi?id=1490928
• https://bugzilla.mozilla.org/show_bug.cgi?id=1487509

So I wonder limiting the effect only to the pref==true still affects some users.

(In reply to Kagami :saschanaz from comment #5)

(In reply to Tooru Fujisawa [:arai] from comment #4)

oh, also I cannot invoke drag event on web content.

Can you invoke drag event in Chrome? We are planning to consume the new WM_POINTER_* events and it's known that Windows does not allow drag and drop with it.

Yes, it works on chrome 88.0.4324.182 (x86_64) on macOS

tested on https://www.w3schools.com/html/html5_draganddrop.asp

Comment 7

[Tooru Fujisawa [:arai]]

I'll test on windows and report back shortly.

Comment 8

[Tooru Fujisawa [:arai]]

The issue doesn't happen on windows, both with Nightly 87.0a1 (2021-02-18) and chrome canary.
I can drag tabs and web content.

so this seems to be macOS-specific
(not sure about linux. I don't have linux box with pen tablet input configured)

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1693683 - Make sure DND is disabled only on Windows r=edgar

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Thanks!

So I wonder limiting the effect only to the pref==true still affects some users.

The issue doesn't happen on windows, both with Nightly 87.0a1 (2021-02-18) and chrome canary.

Yeah, currently dragging by pen just fires touch events and thus shouldn't be affected, unless the flag is set. DND was already broken with the flag (as it caused hang) and thus disabling DND should improve the UX. (Tab reordering will hopefully be enabled soon, probably by fixing bug 1670446.)

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1692277

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48ab57dc59bc
Make sure DND is disabled only on Windows r=edgar

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/48ab57dc59bc