Closed Bug 1693695 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27691 - [advance-override] Implement the second percentage parameter

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27691 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27691
Details from upstream follow.

b'Xiaocheng Hu <xiaochengh@chromium.org>' wrote:

[advance-override] Implement the second percentage parameter

For upright characters in vertical text layout, the advance of a glyph
is its height instead of width, and therefore we may want a different
scale factor for overriding the advance height instead of width.

Hence, this patch implements the second parameter for use in upright
glyphs in vertical text layout.

Bug: 1137633
Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e
Reviewed-on: https://chromium-review.googlesource.com/2706243
WPT-Export-Revision: 77acff1775600e325bb85442e23381d7b7095515

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-fonts/advance-override-serialization.html
One parameter should be serialized as one parameter: FAIL (Chrome: FAIL, Safari: FAIL)
Two different parameters should be serialized as two parameters: FAIL (Chrome: FAIL, Safari: FAIL)
Two identical parameters should be simplified into one parameter: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-fonts/advance-override-vertical-upright.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66c731d15ae3 [wpt PR 27691] - [advance-override] Implement the second percentage parameter, a=testonly https://hg.mozilla.org/integration/autoland/rev/ba2e6d2462d1 [wpt PR 27691] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/66c731d15ae3
https://hg.mozilla.org/mozilla-central/rev/ba2e6d2462d1

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.