1693696 - Inconsistent arrow panel shadows

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Steps to reproduce:

1. Open a new browser window.
2. Click the hamburger button in the new window.
3. Look at the arrow panel's shadow.
4. Click outside the panel to close it.
5. Click the hamburger button again.

Expected results:
The shadow should look the same as before.

Actual results:
On second opening, the shadow looks darker and less soft.

This also happens for the toolbar overflow panel. It does not apply on some other panels.
The difference seems to be whether the panel is resized before it's opened.

It turns out that the hard dark shadow is actually the shadow style we explicitly set in AdjustShadowStyle, and the soft shadow is the default from the system. On first opening, and on opening-after-resize, our override seems to fail and we get the default (softer) shadow.

So this means there are two things wrong:

• Our custom shadow style looks bad (too dark and too hard). These arrow panels all use -moz-window-shadow-style: default.
• Our custom shadow override is brittle and doesn't work most of the time.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1693696 - Switch custom window shadows to a different (private) API: Override -[NSWindow shadowOptions] instead of calling CGSSetWindowShadowAndRimParameters. r=#mac-reviewers

CGSSetWindowShadowAndRimParameters was interfering with the window's built-in
mechanism to update shadow styles. The shadowOptions API should be less brittle.

This also lets us get rid of the hardcoded window shadow parameters, which were
based on macOS Yosemite and which look out of place on Big Sur.

This patch also explicitly makes us only support different shadow types if the
window is a PopupWindow. We effectively had the same behavior before, due to
the canBecomeKeyWindow check.

This patch also changes how the default style is treated: Rather than being
the style for a normal top-level window, it's now the style of a regular
menu/panel. Our arrow panels use default, so this makes them look better.
The StyleWindowShadow::Sheet value is unused and we now treat it as default.

Depends on D105708

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc9b78f73b0a
Switch custom window shadows to a different (private) API: Override -[NSWindow shadowOptions] instead of calling CGSSetWindowShadowAndRimParameters. r=mac-reviewers,spohl

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cc9b78f73b0a