169371 - uninstall of GRE is not really uninstall (files and reg.db entry left behind)

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Henrik Gemal]

Ohh no:
the following are left after installing GRE and then uninstall it:

HKEY_CURRENT_USER\Software\Mozilla\GRE\1.2b
c:\Program Files\Mozilla\GRE\.autoreg

Comment 1

[Charles Rosendahl]

As of the 20021002 build, the uninstaller (when run from control
panel->add/remove programs) removes all registry entries.

However, the following is still left behind:

%program files%\mozilla.org\GRE\%gre_version%\.autoreg
%program files%\mozilla.org\GRE\%gre_version%\install_wizard.log

I would think that the GRE uninstaller removes everything, up to the GRE
directory (provided no other apps are registered to use it), as well as the GRE
directory if %version% is the last installation instance within the directory.

Comment 2

[Curt Patrick (gone)]

I'll look at this more closely.  I'm not sure what is up with the .autoreg file,
but I think the problem with install_wizard.log is that it shouldn't be there to
begin with.  Seems to me that this file is supposed to get moved into the
uninstall directory upon completion of a successful install and recently it
started being copied instead of moved.  Sean, am I just imagining that that is
how it is supposed to work?

Comment 3

[Sean Su]

that's correct.  the install_wizard.log should have been moved into the
uninstall subdir and renamed to contain a sequential number as part of the
filename.  If it's still in the main install dir, it usually means that the
installation did not complete.

Comment 4

[Henrik Gemal]

doing an GRE install then uninstall on a clean system leaves me with the 
following file:
%program files%\mozilla.org\GRE\%gre_version%\.autoreg

AND the following reg.db entry:
HKEY_CURRENT_USER\Software\mozilla.org\GRE\1.2b

please also make sure to remove the reg.db entry!

Comment 5

[Curt Patrick (gone)]

mine

Comment 6

[Curt Patrick (gone)]

Attachment: Patch 1

My tests indicate that only the .autoreg file is still being missed so that is
what this patch takes care of.	If you still see any cases in which the
uninstall log file remains we'll have to chase that down further.

Comment 7

[[e-mail] (away - not reading bugmail)]

Comment on attachment 105120 [details] [diff] [review]
Patch 1

r=jbetak

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 105120 [details] [diff] [review]
Patch 1

If the GRE ever ran this file should go away on its own. If it doesn't then
it's in the wrong place and shouldn't be generated in the first place. But if
this makes people happy...

sr=dveditz

Comment 9

[Henrik Gemal]

The patch only fixes one of the reported problems. The reg.db entry:
HKEY_CURRENT_USER\Software\mozilla.org\GRE\1.2b
is still left over.

The uninstaller should remove the entire:
HKEY_CURRENT_USER\Software\mozilla.org\GRE\[version]
key

Comment 10

[Curt Patrick (gone)]

I'm not seeing this problem anymore.  I've got about 8 patches stacked up
waiting for the branch to happen so that I can check them in.  It may that this
was corrected in one those patches on my machine.  When I can check in I'll
apply this patch and then we can do some further testing to find out if you are
seeing something different from what I'm seeing, or if the problem has been
fixed via some other patches that just are't in the tree yet.

Comment 11

[Curt Patrick (gone)]

Checked in.  Let me know if you still see any of the other failed cleanups.

Comment 12

[Charles Rosendahl]

Verified with the following caveat:  on my system I still see an empty key for
[hkey_current_user]\software\mozilla.org\gre\1.2b\setup

Everything else is clean.

Comment 13

[Sean Su]

I'm working on a patch for a different bug that should deal with that empty key
(in a general case).