Closed Bug 1693783 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 27701 - Avoid fragmentainer overflow from children of monolithic content.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27701 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27701
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Avoid fragmentainer overflow from children of monolithic content.

Checking if the border box of a monolithic element can fit in the
current fragmentainer isn't enough. Children may overflow its border
box, and it's this size that we need to consider when determining
whether a monolithic element can fit in the current fragmentainer, or if
we have to push it to the next one.

Had to add a work-around to
fast/multicol/vertical-lr/balancing/balance-unbreakable.html to prevent
the (monolithic) IMG element (with alt text) in the test from messing
up. The broken image symbol got incorrectly aligned and therefore
incorrectly contributed to overflow. Reported crbug.com/1178743 for
this. Use a real image as a work-around. My first attempt was to switch
the IMG to writing-mode:horizontal-tb, but that messes up legacy column
balancing. Oh well...

Bug: 1178742
Change-Id: Iffbe55d53f32003ae58b574bb6a38745bb92d42e
Reviewed-on: https://chromium-review.googlesource.com/2696632
WPT-Export-Revision: bf98500010463a2d258616d95f088d03d8fd8c8d

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/monolithic-with-overflow.html: FAIL

New Tests That Don't Pass

/css/css-break/monolithic-with-overflow.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75f4581377aa [wpt PR 27701] - Avoid fragmentainer overflow from children of monolithic content., a=testonly https://hg.mozilla.org/integration/autoland/rev/47722741b38b [wpt PR 27701] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.