Open Bug 1693784 Opened 4 years ago Updated 1 year ago

find toolbar highlight on scrollbar doesn't work on PDFs

Categories

(Firefox :: PDF Viewer, enhancement, P3)

Firefox 87
enhancement

Tracking

()

People

(Reporter: u662737, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [pdfjs-feature])

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Open a pdf file in firefox. search a world.

Actual results:

It doesn't show highlight on scrollbar

Expected results:

It should highlight on scrollbar

Version: Firefox 85 → Firefox 87

The Bugbug bot thinks this bug should belong to the 'Firefox::PDF Viewer' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → PDF Viewer
Component: PDF Viewer → Find Toolbar
Product: Firefox → Toolkit

Note: Scroll marks were added to Nightly recently in bug 259640.

This is not necessarily caused by the built-in viewer being a chrome page: the same issue appears on the web app version demo at https://mozilla.github.io/pdf.js/web/viewer.html

I think the new feature may be limited to scroll bars on the body element? In pdf.js, the vertical scrollbar is not on the body element but on the absolutely positioned div#viewerContainer (the body has height: 100%).

(In reply to masih from comment #0)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Open a pdf file in firefox. search a word.

Actual results:

It doesn't show highlight on scrollbar

Expected results:

It should highlight on scrollbar

This may be the effect of an PDF.js implementation detail, but I feel like this is a PDF.js integration issue in essence.

Blocks: 259640
Component: Find Toolbar → PDF Viewer
Product: Toolkit → Firefox

Yes, the highlights are limited to the scrollbar on a window or frame. Chrome does the same thing. We could find a way to special case the integrated pdf viewer in some way, but the scrollable area is a deeply nested element.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: -- → S2
Severity: S2 → --
Type: defect → enhancement
Priority: -- → P3
Whiteboard: [pdfjs-feature]
You need to log in before you can comment on or make changes to this bug.