1693821 - Random BING Double ad_clicks recorded

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Pablo]

Bing ad clicks are showing double in telemetry most of the times.

Tested on
Ubuntu 20.10
Windows 10 64bit

Affected
Firefox Release 85.0.2
Firefox beta 86
Firefox Nightly 87.0a1

Preconditions
-New profile
-browser.newtabpage.activity-stream.improvesearch.handoffToAwesomebar off
-Bing set as default engine
-browser.search.region US

Steps
-Launch firefox with preconditions
-Search "lenovo laptop" in urlbar
-Click on the first line that has an [AD]
-go to about:telemetry > raw json > Raw data
-search ad_clicks

expected result
browser.search.ad_clicks" is: "bing:sap": 1

Actual result
Most of the times we get "bing:sap": 2
randomly "bing:sap": 1 appears.
and randomly there is no result (related to bug 1654280)

Altho its random, on my machine i see bing:sap:2 most of the times.

Comment 1

[Mark Banner (:standard8)]

I think the issue here is that we're tracking two urls that are both being loaded by Bing. Whether or not they were loading both of those originally when we landed these probes I don't know. However, from what I've seen, just tracking one would be correct.

This is a remote settings update and unit test change, so I'll start getting these out.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1693821 - Update tracking regexps for search ad telemetry.

Comment 3

[Mark Banner (:standard8)]

The configuration update was pushed live on remote settings at 13:08 UTC.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61e00c4df530
Update tracking regexps for search ad telemetry. r=mikedeboer

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a7059c55eeb

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/61e00c4df530

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/4eea0915e4e9

Comment 8

[Adrian Florinescu [:aflorinescu]]

This issue has been verified and re-verified across several releases so far, with positive results. Seems like it would be safe to mark as verified.