Use new Proton assets for the AppMenu
Categories
(Firefox :: Menus, task, P2)
Tracking
()
People
(Reporter: mconley, Assigned: emmamalysz)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-hamburger-menu] [priority:2c][proton-icons] [proton-uplift])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Specifically, these are for the Zoom control icons (+, -, fullscreen), as well as the sync progress icon.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Change zoom in, zoom out, full screen, and syncing icons
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f823b4ba2375 change app menu icons r=mconley
Comment 4•3 years ago
|
||
Backed out changeset f823b4ba2375 (bug 1693856) for Build bustage in mozapps/installer/packager.mk. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=338202862&repo=autoland&lineNumber=75203
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=f823b4ba2375a5285c9f9f18cc270c5ee2d56599
Backout:
https://hg.mozilla.org/integration/autoland/rev/9bb369185b518fe8a9ce231072a023599ba6ccfe
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f560d38763d change app menu icons r=mconley
Comment 6•3 years ago
|
||
Backed out for build bustages on zoom-in.svg
Backout link: https://hg.mozilla.org/integration/autoland/rev/433b1203f3985fe17c9aaa360ab9a61f709cde2c
Log link: https://treeherder.mozilla.org/logviewer?job_id=338229746&repo=autoland&lineNumber=61319
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18beaf4ff7f3 change app menu icons r=mconley
Comment 8•3 years ago
|
||
bugherder |
Reporter | ||
Comment 9•3 years ago
|
||
Comment on attachment 9219074 [details]
Bug 1693856, change app menu icons
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Asset swap for new Proton icons.
- String changes made/needed: None.
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Comment on attachment 9219074 [details]
Bug 1693856, change app menu icons
Approved for 89 beta 7, thanks.
Comment 11•3 years ago
|
||
bugherder uplift |
Comment 12•3 years ago
|
||
I can confirm that the zoom icons has the old design on Fx 88.0.1 using Win 10.
Verified - Fixed on the latest Fx 89.0b14 and Nightly 90.0a1 using Win 10, Ubuntu 18.04x64 and MacOS 11.2.3.
Updated•3 years ago
|
Description
•