1693860 - [WEBHOOKS] The Webhook push connector needs to return more details when an error occurs instead of just the code

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[David Lawrence [:dkl]]

In some webhooks we are getting errors such as "Expected HTTP 200 response, got 422" and that is it. It should also include any other details available in the log entry.

Relevant code from the Webhook connector:

my $headers = HTTP::Headers->new(Content_Type => 'application/json');
    my $request
      = HTTP::Request->new('POST', $webhook->url, $headers, encode_json($payload));
    my $resp = $self->_user_agent->request($request);
    if ($resp->code != 200) {
      die "Expected HTTP 200 response, got " . $resp->code;
    }
    else {
      return PUSH_RESULT_OK;
    }

Comment 1

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 2

[David Lawrence [:dkl]]

Merged to master.