Closed Bug 1693889 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27711 - Children of MathML containers always establish a new FC.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27711 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27711
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Children of MathML containers always establish a new FC.

Just like flex and grid items, children of MathML containers establish a
new formatting context. When falling back to legacy layout at a
descendant, stop legacy fallback propagation at such ancestors (since
they cannot be laid out by the legacy engine - no implementation there).

Add a DCHECK to catch such problems earlier (rather than in layout).

This also fixes a similar issue for css-layout-api, unless we make an
extra effort not to fix it. :) So added a test that used to DCHECK-fail
in the exact same way.

Bug: 1178979
Change-Id: Ib76cdc226147c454c4e3de91a300af1295e8aa35
Reviewed-on: https://chromium-review.googlesource.com/2705086
WPT-Export-Revision: 0a9c67662b1af43db134c714d9d900e36377c10f

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS : 2

Chrome

CRASH: 2

Safari

PASS : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/511c479923d8 [wpt PR 27711] - Children of MathML containers always establish a new FC., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09751536a87e [wpt PR 27711] - Children of MathML containers always establish a new FC., a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc8bbd60e4b3 [wpt PR 27711] - Children of MathML containers always establish a new FC., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.