1693929 - Remove the sideloaded extension warning banner code

Status: RESOLVED INVALID

(WebExtensions :: Frontend, task, P5)

Description

[Mike Conley (:mconley) (:⚙️)]

According to https://blog.mozilla.org/addons/2020/03/10/support-for-extension-sideloading-has-ended/, support for sideloading has ended.

Can we get rid of this code that warns about sideloaded add-ons in the AppMenu? Or is this still useful somehow?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey mixedpuppy, do you know if we can get rid of this sideloaded add-on warning message code?

Comment 2

[Shane Caraveo (:mixedpuppy)]

From what I understand, we're removing the notification in the app menu, which we feel is fine to do. Sideloading is still supported, just in limited locations and requiring user interaction to enable.

Comment 3

[:Gijs (he/him)]

Now this is in fluent but apparently still around - https://searchfox.org/mozilla-central/rev/fcb776c1d580000af961677f6df3aeef67168a6f/browser/base/content/browser-addons.js#1800 . Coverage says the code does get hit but that might just be an equally obsolete test, or something? Will touched some of this in bug 1955942 - perhaps he can clarify how alive this is supposed to still be.

Comment 4

[William Durand [:willdurand] (PTO Aug 10-30)]

Per Comment 2:

Sideloading is still supported, just in limited locations and requiring user interaction to enable.

There is some UI for that user interaction, which is what's been discussed in that bug. The same (or similar) UI is also used by the migration wizard (indirectly) when we import extensions from another browser. I don't think we can get rid of this code atm.

Comment 5

[:Gijs (he/him)]

Closing per comment #4, then.