1693950 - test_menulist_position.xhtml fails on macOS with the non-native theme enabled

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 1693950: Ensure that chrome tests continue to use the native theme to not lose test coverage since we do not intend to enable the non-native theme in chrome at this time. r=emilio,mstange

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: test.log

This test probably never tested what it was pretending to. It looks like the test was trying to verify that button b1 does not show a focus ring after being clicked by comparing the appearance of button b1 that was just clicked to another button b2. However, the test then expects the snapshots to not match, which basically means the test was expecting a focus ring after all. The reason why this test didn't fail before is because there is some consistent fuzziness in the two snapshots when using the native theme that disappears when we switch to the non-native theme.

I have manually created this log file to upload to our Reftest analyzer to visualize the differences between native theme and non-native theme.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74607627d1da
Ensure that chrome tests continue to use the native theme to not lose test coverage since we do not intend to enable the non-native theme in chrome at this time. r=mstange

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/74607627d1da