Closed
Bug 1694090
Opened 5 years ago
Closed 5 years ago
Dont await for startListening on each loop iteration in ResourceWatcher#_onTargetAvailable
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox88 fixed)
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
When doing a target switch, on the resource watcher we want to re-watch the resources we were listening for, by calling _startListening: https://searchfox.org/mozilla-central/rev/c8ce16e4299a3afd560320d8d094556f2b5504cd/devtools/shared/resources/resource-watcher.js#329-331
Here we're awaiting on each loop iteration, which can cause some delay and isn't necessary.
| Assignee | ||
Comment 1•5 years ago
|
||
This wasn't needed and could introduce unnecessary delays, so we do all the calls
at the same time and then await for all the calls to be settled.
Depends on D105943
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc7d09777e85
[devtools] Don't await for startListening on each loop iteration in ResourceWatcher#_onTargetAvailable. r=jdescottes.
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•