1694139 - Mixed content download protection creates but doesn't clean up second file

Status: VERIFIED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Juliana Gaibler [:juliana]]

Attachment: image.png

When the mixed content download protection halts a download, there are two files. The first is an empty file, that will contain the downloaded data when the download is allowed or gets deleted if not.
The second file ends with .part, which is a couple of KB big, and doesn't get cleaned up in either scenario.

STR:

1. Turn off HTTPS-Only Mode (if enabled)
2. Go here https://www.thinkbroadband.com/download
3. Download one of the files
4. allow the file to be downloaded in the panel (or reject it)

Expected result:

There is either one file (the downloaded one) or no new files in the downloads directory.

Actual result:

A .part file is also in the downloads directory.

Comment 1

[Juliana Gaibler [:juliana]]

Attachment: Bug 1694139 - Remove .part-files when download is canceled by mixed download protection.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df4e293c71b9
Remove .part-files when download is canceled by mixed download protection. r=mak

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/df4e293c71b9

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 06-10 July, please ni? :mboldan]]

Reproduced the initial issue with Firefox 89.0a1 (20210222214056) on Windows 10x64.
The issue is verified fixed with Firefox 89.0b3 (20210422190146) on Windows 10x64, macOS 11.2.3 and Ubuntu 20. The .part file is removed after the download with HTPS disabled.