Install a telemetry probe for CSS parse errors on UI resources
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
People
(Reporter: zbraniecki, Unassigned)
References
(Blocks 1 open bug)
Details
As part of bug 1675823 and analogously to JS probe being added in bug 1694067 and HTML probe in bug 1694175, we'd like to have a probe that fires an Event when CSS resource encounters a parse error.
It may not be an YSOD, but it likely leads to UI breakage.
I'm going to add the Event in JS bug, and for this bug I'd like to ask:
- Where in CSS parser code such probe should be introduced?
- How to get the file name and line/col and potentially error code?
|
Reporter | |
Comment 1•4 years ago
|
||
:emilio pointed out https://searchfox.org/mozilla-central/rev/c8ce16e4299a3afd560320d8d094556f2b5504cd/servo/components/style/parser.rs#125 which gives us source location - https://searchfox.org/mozilla-central/source/third_party/rust/cssparser/src/tokenizer.rs#533 and https://searchfox.org/mozilla-central/source/servo/components/style/error_reporting.rs#18
|
|
Reporter | |
Comment 2•4 years ago
|
||
:emilio further suggested to install the event in https://searchfox.org/mozilla-central/rev/c8ce16e4299a3afd560320d8d094556f2b5504cd/layout/style/ErrorReporter.cpp#207
Description
•