1694263 - Separate out CSS, JSON and HTML in zero_byte_load telemetry

Status: RESOLVED FIXED

(Core :: Networking: JAR, task, P2)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Based on my current analysis, I think it would be good to separate out from others category the following file types:

• CSS
• JSON
• HTML
• PNG
• SVG

Especially HTML is experiencing a very large volume of NS_ERROR_FAILURE errors in UI documents that would be helpful to analyze as its own category.

Additionally, I learned that our zero_byte_load event is also capturing non-zero-byte broken loads. I don't think it's worth changing the name of the probe at this point, but maybe worth recognizing it in the probe description?

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

I actually filtered out JSON, PNG and SVG in bug 1693955. I think we should bring them back.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1694263 - P1: ODA should not be called when the channel is cancelled

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1694263 - P2: Record more file types in zero_byte_load telemetry

Depends on D106138

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/064ae7c20c88
P1: ODA should not be called when the channel is cancelled r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/710357ff85da
P2: Record more file types in zero_byte_load telemetry r=zbraniecki

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/064ae7c20c88
https://hg.mozilla.org/mozilla-central/rev/710357ff85da

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1694263 - Folded patch for beta uplift

Comment 7

[Kershaw Chang [:kershaw]]

Comment on attachment 9205118 [details]
Bug 1694263 - Folded patch for beta uplift

Beta/Release Uplift Approval Request

• User impact if declined: We'd like to fine tune the telemetry probe that can help us understand the correlation of YSOD and the reason why a JAR cahnnel is failed to load.
  Without this patch, this probe is not consistent with the one we have on nightly, so this makes it harder to analyze the data.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change in this patch is all about collecting telemetry events, so the risk should be low.
• String changes made/needed: N/A

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9205118 [details]
Bug 1694263 - Folded patch for beta uplift

Approved for 87.0b3.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/307d3c490560