1694352 - Intermittent devtools/client/framework/test/browser_target_parents.js | Uncaught exception - at chrome://browser/devtools/client/framework/test/browser_target_parents.js:65 - TypeError: can't access property "descriptorFront", addonFront is null

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=330873860&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TleE_aTbSV-kqIxt5dQEow/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-02-23T09:25:41.054Z] 09:25:41     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js | All the targets returned by concurrent calls to getTarget are the same - 
[task 2021-02-23T09:25:41.055Z] 09:25:41     INFO - Leaving test bound 
[task 2021-02-23T09:25:41.055Z] 09:25:41     INFO - Entering test bound 
[task 2021-02-23T09:25:41.055Z] 09:25:41     INFO - Buffered messages finished
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_target_parents.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:65 - TypeError: can't access property "descriptorFront", addonFront is null
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - Stack trace:
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - @chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:65:1
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - Async*@chrome://mochitests/content/browser/devtools/client/framework/test/browser_target_parents.js:62:8
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1089:34
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1129:11
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:949:14
[task 2021-02-23T09:25:41.056Z] 09:25:41     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
[task 2021-02-23T09:25:41.061Z] 09:25:41     INFO - Leaving test bound 
[task 2021-02-23T09:25:41.061Z] 09:25:41     INFO - Entering test bound 
[task 2021-02-23T09:25:41.061Z] 09:25:41     INFO - GECKO(2220) | [Parent 2220, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp:4254
[task 2021-02-23T09:25:41.061Z] 09:25:41     INFO - TEST-PASS | devtools/client/framework/test/browser_target_parents.js```

Comment 1

[Cosmin Sabou [:CosminS]]

This might be related to the patches landed in Bug 1685474: https://bugzilla.mozilla.org/show_bug.cgi?id=1685474#c13
Alexandre, please have a look over these kind of failures. Thank you.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1685474

Comment 3

[Intermittent Failures Robot]

26 failures in 4327 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 21
• mozilla-central: 3
• try: 2

Platform and build breakdown:

• windows10-64: 1
  • asan: 1
• linux1804-64: 5
  • debug: 4
  • opt: 1
• linux1804-64-asan: 14
  • opt: 14
• macosx1014-64-qr: 3
  • opt: 1
  • debug: 2
• linux1804-64-shippable: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694352&startday=2021-02-22&endday=2021-02-28&tree=all

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I reverted patches from Bug 1685474 (using hg diff -r bb6cddd372c2c95b04ce2930c8f7362822472d01 -r 7d8728cb6a1d --reverse to generate the patch and then applying it), and I was still able to trigger the test failure.
Cosmin, are there any other suspect for this regression?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There are ~6 failures/day. The first failure is this one and none of the 13 retriggers and backfills reproduced the issue but the issues hit another 3 times in the next 3 hours which suggested the failure is a regression from one of those check-ins near the first failure.

Comment 6

[Cosmin Sabou [:CosminS]]

So retriggers point to Bug 1690573. Before that there are Android only changes (Bug 1684923) and two pushes each with 40 green runs.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=331837453&repo=autoland
Mike, could you have a look over these failures? Thank you.

Comment 7

[Intermittent Failures Robot]

35 failures in 3683 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #26 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 28
• mozilla-central: 3
• try: 4

Platform and build breakdown:

• linux1804-64-asan: 26
  • opt: 26
• macosx1014-64-qr: 2
  • opt: 2
• linux1804-64: 4
  • debug: 3
  • opt: 1
• linux1804-64-shippable: 1
  • opt: 1
• windows10-64: 1
  • asan: 1
• macosx1014-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694352&startday=2021-03-01&endday=2021-03-07&tree=all

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694352 - [devtools] Throw explicit error when connecting to a web extension that got destroyed.

Better acknowledge that connectToFrame may resolve null in case of
destroyed addon while connectToFrame was processing.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694352 - [devtools] Avoid debugging addons that are still starting up.

Comment 10

[Intermittent Failures Robot]

32 failures in 4622 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #40 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 30
• try: 2

Platform and build breakdown:

• linux1804-64-asan: 18
  • opt: 18
• linux1804-64: 11
  • debug: 10
  • opt: 1
• macosx1014-64-qr: 2
  • opt: 2
• windows10-64: 1
  • asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694352&startday=2021-03-08&endday=2021-03-14&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e0113209ceb
[devtools] Throw explicit error when connecting to a web extension that got destroyed. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/57eab193fdc5
[devtools] Avoid debugging addons that are still starting up. r=nchevobbe,rpl

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3e0113209ceb
https://hg.mozilla.org/mozilla-central/rev/57eab193fdc5

Comment 13

[Intermittent Failures Robot]

5 failures in 4257 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 3
• try: 1

Platform and build breakdown:

• linux1804-64-asan: 3
  • opt: 3
• linux1804-64: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1694352&startday=2021-03-15&endday=2021-03-21&tree=all