Closed Bug 1694391 Opened 3 years ago Closed 2 years ago

Implement browsingContext.getTree command

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
8

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [bidi-m3-mvp], [wptsync upstream])

Attachments

(5 files)

Bug 1694391 - [remote] Make TabManager.browsers a getter.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694391 - [webdriver-bidi] Implement browsingContext.getTree command.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694391 - [wdspec] Added web-platform tests for browsingContext.getTree command.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694391 - [webdriver-client] Add browsing context module to WebDriver BiDi client.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1694391 - [wdspec] Remove duplicated NoSuchFrameException
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Depends on: 1693839
Points: --- → 8
Priority: -- → P2
Whiteboard: [bidi-m1-mvp] → [bidi-m1-mvp] [not-a-fission-bug]
Priority: P2 → P3
Whiteboard: [bidi-m1-mvp] [not-a-fission-bug] → [bidi-m2-mvp]
Priority: P3 → --
Blocks: 1730466
Points: 8 → ---
Priority: -- → P2
Points: --- → 8
Priority: P2 → P3

Deserialization is actually not required for this command.

URL: https://w3c.github.io/webdriver-bidi/... → https://w3c.github.io/webdriver-bidi/...
No longer depends on: 1693839
Priority: P3 → P2
Whiteboard: [bidi-m2-mvp] → [bidi-m3-mvp]
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: Implement browsingContext.getTree() → Implement browsingContext.getTree command
Blocks: 1754273
Depends on: 1758572
Attachment #9267186 - Attachment description: WIP: Bug 1694391 - [remote] Make TabManager.browsers a getter. → Bug 1694391 - [remote] Make TabManager.browsers a getter.
Attachment #9267187 - Attachment description: WIP: Bug 1694391 - [webdriver-bidi] Implement browsingContext.getTree command. → Bug 1694391 - [webdriver-bidi] Implement browsingContext.getTree command.
Attachment #9267329 - Attachment description: WIP: Bug 1694391 - [webdriver-client] Add browsing context module to WebDriver BiDi client. → Bug 1694391 - [webdriver-client] Add browsing context module to WebDriver BiDi client.
Attachment #9267188 - Attachment description: WIP: Bug 1694391 - [wdspec] Added web-platform tests for browsingContext.getTree command. → Bug 1694391 - [wdspec] Added web-platform tests for browsingContext.getTree command.

Note that there was also a need to make changes to the WebDriver BiDi specification:
https://github.com/w3c/webdriver-bidi/pull/181

See Also: → https://github.com/w3c/webdriver-bidi/pull/181
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e59368ee5d32
[remote] Make TabManager.browsers a getter. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/850664ee7690
[webdriver-bidi] Implement browsingContext.getTree command. r=webdriver-reviewers,jdescottes,jgraham
https://hg.mozilla.org/integration/autoland/rev/dcfe0ab9025d
[webdriver-client] Add browsing context module to WebDriver BiDi client. r=jgraham,webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/dd61f79731b9
[wdspec] Added web-platform tests for browsingContext.getTree command. r=webdriver-reviewers,jgraham,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33258 for changes under testing/web-platform/tests
Whiteboard: [bidi-m3-mvp] → [bidi-m3-mvp], [wptsync upstream]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #9)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/33258 for changes under
testing/web-platform/tests

The merge of the PR is blocked due to some flake8 failures. I pushed a commit to the upstream branch to fix that.

Upstream PR merged by jgraham
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/676a7daeee86
[wpt PR 33258] - [Gecko Bug 1694391] [webdriver-client] Add browsing context module to WebDriver BiDi client., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07994bf19a79
[wpt PR 33258] - [Gecko Bug 1694391] [webdriver-client] Add browsing context module to WebDriver BiDi client., a=testonly
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dd6ba2d423c
[wdspec] Remove duplicated NoSuchFrameException r=jgraham,webdriver-reviewers
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
Whiteboard: [bidi-m3-mvp], [wptsync upstream] → [bidi-m3-mvp], [wptsync upstream error]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #17)

Failed to create upstream wpt PR due to merge conflicts. This requires fixup
from a wpt sync admin.

The fix was only needed in mozilla-central due to a bad merge. Upstream isn't affected and as such explains the merge conflict. No further action is needed here.

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33431 for changes under testing/web-platform/tests
Whiteboard: [bidi-m3-mvp], [wptsync upstream error] → [bidi-m3-mvp], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: