1694403 - Downgrade "Already started legacy listener" error messages to warnings

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

These messages can be displayed whenever target list emits a target a bit too early and the resource watcher ends up processing it twice.

Until we actually fix this flaw in the TargetList design, we should only log warnings at https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/devtools/shared/resources/resource-watcher.js#753

Comment 1

[Julian Descottes [:jdescottes]]

Definitely a good first bug for anyone who wants to setup the development environment.

To be really explicit about the expected change here:

      console.error(
        `Already started legacy listener for ${resourceType} on ${targetFront.actorID}`
      );

should be changed from error() to warn():

      console.warn(
        `Already started legacy listener for ${resourceType} on ${targetFront.actorID}`
      );

https://searchfox.org/mozilla-central/rev/f47a4b67643b3048ef9a2e2ac0c34edf6d1ebff3/devtools/shared/resources/resource-watcher.js#752

Comment 2

[RAHUL SAWRA[:rsawra]]

Hello Julian, I would like to work on the issue.

Comment 3

[Julian Descottes [:jdescottes]]

Hi Rahul! Thanks for proposing to work on this bug, assigning it to you right now.

If this is your first contribution to firefox and you need to setup your development environment, take a look https://firefox-source-docs.mozilla.org/contributing/index.html and don't hesitate to ask around on https://chat.mozilla.org if you are stuck

For the change itself there's not much more to it than what I mentioned in comment 1, but again don't hesitate to ask if you have any question.

You can also use the "Request information from" field below this comment box. It's the best way to notify people when you have a question.

Comment 4

[RAHUL SAWRA[:rsawra]]

Sure Julian. Will start to work on it.

Comment 5

[RAHUL SAWRA[:rsawra]]

Attachment: Bug 1694403 - Downgrade "Already started legacy listener" error messages to warnings . r=jdescottes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/904e4e21363c
Downgrade "Already started legacy listener" error messages to warnings . r=jdescottes

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/904e4e21363c