Closed Bug 1694476 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27745 - Add test for <source> width/height

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27745 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27745
Details from upstream follow.

b'Christian Biesinger <cbiesinger@chromium.org>' wrote:

Add test for <source> width/height

This is for https://github.com/whatwg/html/pull/5894

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
PR 27745 applied with additional changes from upstream: 2f27da8fda37f5d96b9e5a17bb394494ee5fc98b

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 11 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 9

Chrome

OK : 1
PASS: 2
FAIL: 9

Safari

OK : 1
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio.html
source width and height attributes are used to infer aspect-ratio in <picture>: FAIL (Chrome: FAIL, Safari: FAIL)
Computed style for width/height/aspect-ratio: FAIL (Chrome: FAIL, Safari: FAIL)
Source width/height should take precedence over img attributes.: FAIL (Chrome: FAIL, Safari: FAIL)
If the <source> has only one of width/height, we don't get an aspect ratio, even if the <img> has both.: FAIL (Chrome: FAIL, Safari: FAIL)
If we only have one width/height attribute, we should get that attribute mapped but no aspect ratio, even if <img> has attributes.: FAIL (Chrome: FAIL, Safari: FAIL)
Dynamically changing width/height should change computed style: FAIL (Chrome: FAIL, Safari: FAIL)
Changing which <source> matches should change computed style: FAIL (Chrome: FAIL, Safari: FAIL)
Percentages on source should be ignored for aspect-ratio but used for width/height.: FAIL (Chrome: FAIL, Safari: FAIL)
Trailing garbage should be ignored but not make the attribute invalid: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19dce124c96b
[wpt PR 27745] - Split the big test() up into multiple small ones, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a5af1fd51aed
[wpt PR 27745] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.