1694496 - Implement the "rate" metric type in FOG

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

Should just have to follow the steps in the docs for adding a new metric type to FOG. If not, updating the docs is now part of this bug.

Boils down to:

• Generate RateMetric, DenominatorMetric, and NumeratorMetric instances in Rust, C++, and JS templates.
• Implement those three types in those three languages
• All of these metrics are IPC-supporting, so be sure to add support
• Document the C++ and JS APIs in The Book
• Tests, tests, tests

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1694496 - Update 'add a new metric type' docs r?janerik!

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1694496 - Add 'rate' metric type to FOG (Rust) r?janerik!

Depends on D119784

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1694496 MLA FFI for `rate` metric type r?janerik!

Depends on D119785

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1694496 - FOG Rate metric type C++ and JS r?janerik!

Depends on D119786

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1694496 - GIFFT for FOG rate metric r?janerik!

Depends on D119787

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9591dcd4369d
Update 'add a new metric type' docs r=janerik
https://hg.mozilla.org/integration/autoland/rev/36421c124795
Add 'rate' metric type to FOG (Rust) r=janerik
https://hg.mozilla.org/integration/autoland/rev/887eaee3ab5c
MLA FFI for `rate` metric type r=janerik
https://hg.mozilla.org/integration/autoland/rev/9ccad5fe13e7
FOG Rate metric type C++ and JS r=janerik
https://hg.mozilla.org/integration/autoland/rev/86dc6a0fd554
GIFFT for FOG rate metric r=janerik

Comment 7

[Atila Butkovits]

Backed out for causing build bustages on GleanJSMetricsLookup.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6d266a43f44537899d614915deaf05c2bca483b9

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=86dc6a0fd554ecbec4dd18dc5eb2d5ba6b36858f&selectedTaskRun=YUUDPJDDQx-mkXri4bxGrg.0&searchStr=Linux%2Cx64%2Cdebug%2Cbuild-linux64%2Fdebug%2CB

Failure log: https://treeherder.mozilla.org/logviewer?job_id=345210684&repo=autoland&lineNumber=54143

Comment 8

[Chris H-C :chutten]

Attachment: Bug 1694496 - Annotate FOG JS PHF entries for their widths r?janerik!

Without these annotations the literals will be assumed to be int so as soon
as there's a literal that cannot be represented as such it'll warn.
And CI builds with warnings as errors.

metric_entry_t is uint64_t which is unsigned long long int which is ull
category_entry_t is uint32_t which is unsigned long int which is ul

Depends on D119788

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1716

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/900dae58363c
Update 'add a new metric type' docs r=janerik
https://hg.mozilla.org/integration/autoland/rev/5f7e82456e24
Add 'rate' metric type to FOG (Rust) r=janerik
https://hg.mozilla.org/integration/autoland/rev/15b51f5e1e48
MLA FFI for `rate` metric type r=janerik
https://hg.mozilla.org/integration/autoland/rev/17ecd7307d1e
FOG Rate metric type C++ and JS r=janerik
https://hg.mozilla.org/integration/autoland/rev/aee57341a14a
GIFFT for FOG rate metric r=janerik
https://hg.mozilla.org/integration/autoland/rev/628fd187bba9
Annotate FOG JS PHF entries for their widths r=janerik

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/900dae58363c
https://hg.mozilla.org/mozilla-central/rev/5f7e82456e24
https://hg.mozilla.org/mozilla-central/rev/15b51f5e1e48
https://hg.mozilla.org/mozilla-central/rev/17ecd7307d1e
https://hg.mozilla.org/mozilla-central/rev/aee57341a14a
https://hg.mozilla.org/mozilla-central/rev/628fd187bba9