1694525 - unhandled exception when browsertime fails to start takes 1 hour to exit

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P2)

Description

[Andrew Erickson [:aerickson]]

When browsertime fails to start, mozprocess sits waiting for output for an hour.

See Bug 1694275 for my original report. Task log with stack trace attached to that bug: https://bugzilla.mozilla.org/attachment.cgi?id=9204695

Per :gbrown in the above bug, this is due to an unhandled exception in Raptor's line handler.

The Raptor line handler:

• should use kill() to signal to mozprocess that it's done (when it fails to start, etc)
• ideally, shouldn't throw any exceptions in the line handler (catch all and log)

Comment 1

[Geoff Brown [:gbrown]]

Attachment: Bug 1694525 - End browsertime test process when error encountered; r=

Currently, raising an exception in a mozprocess callback is not guaranteed to
end the managed process; after bug 1694275, the exception will be reported but
otherwise suppressed.
Instead of raising an exception, report the error and end the test process.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ef59030e7c9
End browsertime test process when error encountered; r=perftest-reviewers,sparky

Comment 3

[Geoff Brown [:gbrown]]

This appears to be working as expected:
https://treeherder.mozilla.org/logviewer?job_id=331378948&repo=autoland&lineNumber=920

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8ef59030e7c9