1694533 - JavaScript error: chrome://browser/content/parent/ext-menus.js, line 1196: TypeError: can't access property "bookmarkGuid", node is null

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[:Gijs (he/him)]

STR:

1. open Nightly on a clean profile
2. open Library window
3. switch to History in the left sidebar
4. ensure "Today" is selected on the right hand pane
5. click empty space at the bottom of the right hand pane

ER:

no errors

AR:

JavaScript error: chrome://browser/content/parent/ext-menus.js, line 1196: TypeError: can't access property "bookmarkGuid", node is null

appears in the browser console. There is no further stack.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Rob Wu [:robwu]]

We just need to prepend ? before . in node.bookmarkGuid at https://searchfox.org/mozilla-central/rev/d3b116e554eb3546a95851e81f7ddc53d5b7e096/browser/components/extensions/parent/ext-menus.js#1167

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1694533 - Fix erroneous bookmarkGuid access in ext-menus.js in library window

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74650f5271f1
Fix erroneous bookmarkGuid access in ext-menus.js in library window r=zombie

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/74650f5271f1