169459 - enter_bug.cgi should not lie saying: "Derivatives" is not a valid product.

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[timeless]

http://bugzilla.mozilla.org/buglist.cgi?product=Derivatives
http://bugzilla.mozilla.org/enter_bug.cgi?product=Derivatives

clearly the product exists

suggestion: change "valid product" to something else.

Comment 1

[Matthew Tuck [:CodeMachine]]

"valid product in Bugzilla" ?

Comment 2

[Dave Miller [:justdave]]

Myk: is that a disabled product?  (closed to new bug entry)

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Yup, it's closed.

Comment 4

[Dave Miller [:justdave]]

"The product name 'Derivatives' is invalid, does not exist, or has been closed
to new bug entry."

The trick is to make sure this error message isn't being used somewhere else
where whether it's closed to entry or not is irrelevant.  If it is, it needs to
be split into to errors and/or pass a flag to the error template so it knows
which case to report.

Comment 5

[Vlad Dascalu]

From /template/en/default/global/user-error.html.tmpl:

  [% ELSIF error == "invalid_product_name" %]
    [% title = "Invalid Product Name" %]
    The product name '[% product FILTER html %]' is invalid or does not exist.

Comment 6

[Vlad Dascalu]

On the CVS tip:

[vladd@trinity bugzilla]# grep -R invalid_product_name .
./describecomponents.cgi:    ThrowUserError("invalid_product_name",
./duplicates.cgi:        ThrowUserError("invalid_product_name",
./enter_bug.cgi:    ThrowUserError("invalid_product_name", { product => $product});
./post_bug.cgi:    ThrowUserError("invalid_product_name",
./process_bug.cgi:      ThrowUserError("invalid_product_name", {product =>
$::FORM{'product'}});
./reports.cgi:      || ThrowUserError("invalid_product_name", {product =>
$FORM{'product'}});
\./template/en/default/global/user-error.html.tmpl:  [% ELSIF error ==
"invalid_product_name" %]
./data/template/en/default/global/user-error.html.tmpl:    elsif
($stash->get('error') eq 'invalid_product_name') {


So this error message is used in ./describecomponents.cgi, where it's irrelevant
if the product is closed for bug entries or not. We can't reuse this error message.

Comment 7

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 8

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 9

[Frédéric Buclin]

Taking! This will be fixed by bug 287109.

Comment 10

[Frédéric Buclin]

bug 287109 has been checked in. Fixed in 2.16.9, 2.18.1 and 2.19.3!