Closed Bug 1694614 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27759 - [CrossOriginIsolation] Fix failed navigation leads to browser crash

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27759 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27759
Details from upstream follow.

b'P\xc3\xa2ris MEULEMAN <pmeuleman@chromium.org>' wrote:

[CrossOriginIsolation] Fix failed navigation leads to browser crash

The change in the COOP WPT lead to a crash:

  • main frame is cross origin isolated, with COOP same-origin and COEP
    require-corp.
  • sandboxed iframe opens a popup.
  • popup navigates from about:blank document to a document with COOP set.
  • the last navigation fails: the popup main frame has sandbox flags,
    which is incompatible with COOP.
  • while determining the site-instance for the failed navigation, the
    browser crashes in
    content::RenderFrameHostManager::ConvertToSiteInstance

The suggested fix here, is to apply the same behavior as for speculative
cases during failures.

Bug: 1181673
Fixed: 1181673

Change-Id: Iaef658778ac25da0c84763b6115ff40c105e618a
Reviewed-on: https://chromium-review.googlesource.com/2712945
WPT-Export-Revision: 72a21ef16848a538ce0745a81f3fa74bbc547b25

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS : 4

Chrome

ERROR: 1

Safari

OK : 1
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/cross-origin-opener-policy/coop-coep-sandbox.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: ERROR, Safari: OK)

Tests Disabled in Gecko Infrastructure

/html/cross-origin-opener-policy/coop-coep-sandbox.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: ERROR, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0efa0870799c
[wpt PR 27759] - [COOP] Fix noopener not being applied to same-origin-plus-coep cases, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0efa0870799c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.