1694648 - Extra toolbarseparator is added to app menu panels after the corresponding toolbarbutton is pressed when Proton is enabled

Status: VERIFIED FIXED

(Firefox :: Menus, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

I think that toolbarseparator is being injected programmatically, and we should probably stop doing that if Proton is enabled.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Note that this seems to occur only after synced tabs have loaded in.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey emalysz, do you think you'd have time to look at this today?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Having tinkered with this more, I'm not sure it's necessary to have synced tabs come in. It might be sufficient to just open the Firefox Accounts panel via the fxa toolbarbutton, and then open it in the AppMenu.

Comment 4

[Emma Malysz]

Looks like this is a bug from here: https://searchfox.org/mozilla-central/rev/a6db3bd67367aa9ddd9505690cab09b47e65a762/browser/components/customizableui/PanelMultiView.jsm#1426-1427

This can be reproduced for any panel that is opened from the app menu and then again by the toolbar button (history reproduces as well).

Comment 5

[Emma Malysz]

Attachment: Bug 1694648, ensure toolbarseparators are added correctly for menu headers when proton is enabled

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17ee13de9883
ensure toolbarseparators are added correctly for menu headers when proton is enabled r=mconley

Comment 7

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/17ee13de9883

Comment 9

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build (build id: 20210223230332).
Verified - Fixed in release 88, beta 89.0b10 and latest Nightly 90.0a1 (2021-05-11) on Windows 10, macOS 11 and Ubuntu 20.